Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(986)

Unified Diff: webkit/glue/webview_impl.cc

Issue 149172: Modify ResourceFetcher to use WebURLLoader instead of ResourceHandle.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« webkit/glue/resource_fetcher.cc ('K') | « webkit/glue/webview_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/webview_impl.cc
===================================================================
--- webkit/glue/webview_impl.cc (revision 19821)
+++ webkit/glue/webview_impl.cc (working copy)
@@ -126,6 +126,8 @@
using WebKit::WebRect;
using WebKit::WebSize;
+using webkit_glue::ImageResourceFetcher;
+
// Change the text zoom level by kTextSizeMultiplierRatio each time the user
// zooms text in or out (ie., change by 20%). The min and max values limit
// text zoom to half and 3x the original text size. These three values match
@@ -1417,11 +1419,13 @@
}
}
-bool WebViewImpl::DownloadImage(int id, const GURL& image_url, int image_size) {
+bool WebViewImpl::DownloadImage(int id, const GURL& image_url,
+ int image_size) {
if (!page_.get())
return false;
- image_fetchers_.insert(
- new ImageResourceFetcher(this, id, image_url, image_size));
+ image_fetchers_.insert(new ImageResourceFetcher(
+ image_url, main_frame(), id, image_size,
+ NewCallback(this, &WebViewImpl::OnImageFetchComplete)));
return true;
}
@@ -1853,12 +1857,11 @@
}
}
-void WebViewImpl::ImageResourceDownloadDone(ImageResourceFetcher* fetcher,
- bool errored,
- const SkBitmap& image) {
+void WebViewImpl::OnImageFetchComplete(ImageResourceFetcher* fetcher,
+ const SkBitmap& image) {
if (delegate_) {
- delegate_->DidDownloadImage(fetcher->id(), fetcher->image_url(), errored,
- image);
+ delegate_->DidDownloadImage(fetcher->id(), fetcher->image_url(),
+ image.isNull(), image);
}
DeleteImageResourceFetcher(fetcher);
}
« webkit/glue/resource_fetcher.cc ('K') | « webkit/glue/webview_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698