Issue 149165: Checking in Windows FFmpeg binaries for Chromium.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149165: Checking in Windows FFmpeg binaries for Chromium. (Closed)

Created:
11 years, 5 months ago by scherkus (not reviewing)

Modified:
9 years, 7 months ago

Reviewers:
Daniel Berlin, darin (slow to review), awong

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Checking in Windows FFmpeg binaries for Chromium. BUG=15906 TEST=builds of Chromium should now be video/audio enabled

Patch Set 1 #

Total comments: 1

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -6 lines)			Patch
A	third_party/ffmpeg/binaries/chromium/README.chromium	View	1 chunk	+12 lines, -0 lines	0 comments	Download
A	third_party/ffmpeg/binaries/chromium/avcodec-52.dll	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	third_party/ffmpeg/binaries/chromium/avformat-52.dll	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	third_party/ffmpeg/binaries/chromium/avutil-50.dll	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	third_party/ffmpeg/binaries/chromium/pthreadGC2.dll	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	third_party/ffmpeg/ffmpeg.gyp	View	4 chunks	+22 lines, -10 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

awong

just one comment. http://codereview.chromium.org/149165/diff/1/7 File third_party/ffmpeg/ffmpeg.gyp (right): http://codereview.chromium.org/149165/diff/1/7#newcode174 Line 174: # overwritten due to the ...

11 years, 5 months ago (2009-07-03 01:52:05 UTC) #2

LGTM enough

Expand Messages | Collapse Messages