Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 149164: Fix retarded bitmath. (Closed)

Created:
11 years, 5 months ago by Glen Murphy
Modified:
9 years, 5 months ago
Reviewers:
Nico, Miranda Callahan
CC:
chromium-reviews_googlegroups.com, brettw
Visibility:
Public.

Description

Fix retarded bitmath. << 8 != * 255 BUG=13360 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20040

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M base/gfx/png_decoder.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M base/gfx/png_encoder.cc View 1 2 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Glen Murphy
11 years, 5 months ago (2009-07-06 07:07:43 UTC) #1
Miranda Callahan
LG. On 2009/07/06 07:07:43, Glen Murphy wrote: >
11 years, 5 months ago (2009-07-06 11:55:09 UTC) #2
Nico
deanm suggested using SkUnPreMultiply in a similar codereview ( http://codereview.chromium.org/150151 ).
11 years, 5 months ago (2009-07-06 19:18:28 UTC) #3
Glen Murphy
Right you are, updated.
11 years, 5 months ago (2009-07-07 00:33:28 UTC) #4
Miranda Callahan
11 years, 5 months ago (2009-07-07 00:46:58 UTC) #5
Much more G.

On 2009/07/07 00:33:28, Glen Murphy wrote:
> Right you are, updated.

Powered by Google App Engine
This is Rietveld 408576698