Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issue 149163: A couple of NNTP bug fixes (Closed)

Created:
11 years, 5 months ago by arv (Not doing code reviews)
Modified:
9 years, 3 months ago
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

Make action buttons listen to the enter key. Hide menus when the window is blurred or the user presses Alt or Meta. Only show tooltip for the title of the thumbnail. Allow mouse over on the window menu. Made the windows opaque but with a hsla background color to make it more readable. Quote all background image URLs so that we can display icons for URLs with spaces in them. Call preventDefault when using the keyboard to navigate the options menu so that the page does not scroll. BUG=15268, 15503, 15715, 15769, 15411, 15458 TEST=See bug descriptions Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19884

Patch Set 1 #

Total comments: 10

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -67 lines) Patch
M chrome/browser/resources/new_new_tab.css View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/resources/new_new_tab.html View 1 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/resources/new_new_tab.js View 1 9 chunks +111 lines, -59 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
arv (Not doing code reviews)
11 years, 5 months ago (2009-07-03 01:05:44 UTC) #1
Glen Murphy
LG, nits. http://codereview.chromium.org/149163/diff/1/3 File chrome/browser/resources/new_new_tab.html (right): http://codereview.chromium.org/149163/diff/1/3#newcode233 Line 233: .style.backgroundImage:'url("chrome://favicon/' + url + 80 col ...
11 years, 5 months ago (2009-07-03 01:51:01 UTC) #2
arv (Not doing code reviews)
11 years, 5 months ago (2009-07-03 02:04:16 UTC) #3
http://codereview.chromium.org/149163/diff/1/3
File chrome/browser/resources/new_new_tab.html (right):

http://codereview.chromium.org/149163/diff/1/3#newcode233
Line 233: .style.backgroundImage:'url("chrome://favicon/' + url +
On 2009/07/03 01:51:01, Glen Murphy wrote:
> 80 col (only if you care about it)

Done.

http://codereview.chromium.org/149163/diff/1/3#newcode304
Line 304: jsvalues=".style.backgroundImage:'url("chrome://favicon/' + url +
'")';
On 2009/07/03 01:51:01, Glen Murphy wrote:
> 80 col (only if you care about it)

Done.

http://codereview.chromium.org/149163/diff/1/4
File chrome/browser/resources/new_new_tab.js (right):

http://codereview.chromium.org/149163/diff/1/4#newcode959
Line 959: var windowMenu = {
On 2009/07/03 01:51:01, Glen Murphy wrote:
> Add short description

Done.

Changed to use a constructor and moved the init code into it.

http://codereview.chromium.org/149163/diff/1/4#newcode979
Line 979: //window.addEventListener('blur', this.boundHide_);
On 2009/07/03 01:51:01, Glen Murphy wrote:
> commented out code necessary?

Done.

http://codereview.chromium.org/149163/diff/1/4#newcode988
Line 988: //window.removeEventListener('blur', self.boundHide_);
On 2009/07/03 01:51:01, Glen Murphy wrote:
> commented out code necessary?

Done.

Powered by Google App Engine
This is Rietveld 408576698