Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1727)

Unified Diff: chrome/browser/tab_contents/navigation_controller_unittest.cc

Issue 149155: Initializing the struct before using it, as mandated by... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/tab_contents/navigation_controller_unittest.cc
===================================================================
--- chrome/browser/tab_contents/navigation_controller_unittest.cc (revision 19850)
+++ chrome/browser/tab_contents/navigation_controller_unittest.cc (working copy)
@@ -1,4 +1,4 @@
-// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
+// Copyright (c) 2009 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -738,7 +738,7 @@
EXPECT_EQ(controller().pending_entry_index(), -1);
EXPECT_EQ(url1, controller().GetActiveEntry()->url());
- ViewHostMsg_FrameNavigate_Params params;
+ ViewHostMsg_FrameNavigate_Params params = {0};
params.page_id = 0;
params.url = url2;
params.transition = PageTransition::SERVER_REDIRECT;
@@ -779,7 +779,7 @@
NotificationType::NAV_ENTRY_COMMITTED));
const GURL url2("http://foo2");
- ViewHostMsg_FrameNavigate_Params params;
+ ViewHostMsg_FrameNavigate_Params params = {0};
params.page_id = 1;
params.url = url2;
params.transition = PageTransition::MANUAL_SUBFRAME;
@@ -814,7 +814,7 @@
// Navigation controller currently has no entries.
const GURL url("http://foo2");
- ViewHostMsg_FrameNavigate_Params params;
+ ViewHostMsg_FrameNavigate_Params params = {0};
params.page_id = 1;
params.url = url;
params.transition = PageTransition::AUTO_SUBFRAME;
@@ -839,7 +839,7 @@
NotificationType::NAV_ENTRY_COMMITTED));
const GURL url2("http://foo2");
- ViewHostMsg_FrameNavigate_Params params;
+ ViewHostMsg_FrameNavigate_Params params = {0};
params.page_id = 0;
params.url = url2;
params.transition = PageTransition::AUTO_SUBFRAME;
@@ -869,7 +869,7 @@
// First manual subframe navigation.
const GURL url2("http://foo2");
- ViewHostMsg_FrameNavigate_Params params;
+ ViewHostMsg_FrameNavigate_Params params = {0};
params.page_id = 1;
params.url = url2;
params.transition = PageTransition::MANUAL_SUBFRAME;
@@ -953,7 +953,7 @@
// First navigation.
const GURL url2("http:////foo#a");
- ViewHostMsg_FrameNavigate_Params params;
+ ViewHostMsg_FrameNavigate_Params params = {0};
params.page_id = 1;
params.url = url2;
params.transition = PageTransition::LINK;
@@ -1116,7 +1116,7 @@
EXPECT_EQ(0, our_controller.GetEntryAtIndex(0)->page_id());
// Say we navigated to that entry.
- ViewHostMsg_FrameNavigate_Params params;
+ ViewHostMsg_FrameNavigate_Params params = {0};
params.page_id = 0;
params.url = url;
params.transition = PageTransition::LINK;
@@ -1380,7 +1380,7 @@
// Navigate a subframe that would normally count as in-page.
const GURL subframe("http://www.google.com/#");
- ViewHostMsg_FrameNavigate_Params params;
+ ViewHostMsg_FrameNavigate_Params params = {0};
params.page_id = 0;
params.url = subframe;
params.transition = PageTransition::AUTO_SUBFRAME;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698