Issue 149151: Knock out a couple more TODOs from the bookmark manager....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149151: Knock out a couple more TODOs from the bookmark manager.... (Closed)

Created:
11 years, 5 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Knock out a couple more TODOs from the bookmark manager. TEST=edit the name of a folder; it should update in the left pane. Add a new bookmark URL; it should show up selected in the right pane. Also, see bug BUG=http://crbug.com/15844 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19870

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -3 lines)			Patch
	M	chrome/browser/gtk/bookmark_manager_gtk.cc	View	1	4 chunks	+34 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

added a one line fix for bug 15844, care to look at L185? thx

11 years, 5 months ago (2009-07-02 22:30:13 UTC) #3

LGTM2.

Expand Messages | Collapse Messages