Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7768)

Unified Diff: chrome/browser/printing/print_job.cc

Issue 149148: Remove unused notification in print code to simplify before refactoring.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/browser_main.cc ('k') | chrome/browser/printing/print_job_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/printing/print_job.cc
===================================================================
--- chrome/browser/printing/print_job.cc (revision 19830)
+++ chrome/browser/printing/print_job.cc (working copy)
@@ -66,21 +66,6 @@
const NotificationDetails& details) {
DCHECK_EQ(ui_message_loop_, MessageLoop::current());
switch (type.value) {
- case NotificationType::PRINTED_DOCUMENT_UPDATED: {
- DCHECK(Source<PrintedDocument>(source).ptr() ==
- document_.get());
-
- // This notification may happens even if no job is started (i.e. print
- // preview)
- if (is_job_pending_ == true &&
- Source<PrintedDocument>(source).ptr() == document_.get() &&
- Details<PrintedPage>(details).ptr() != NULL) {
- // Are we waiting for a page to print? The worker will know.
- worker_->message_loop()->PostTask(FROM_HERE, NewRunnableMethod(
- worker_.get(), &PrintJobWorker::OnNewPage));
- }
- break;
- }
case NotificationType::PRINT_JOB_EVENT: {
OnNotifyPrintJobEvent(*Details<JobEventDetails>(details).ptr());
break;
@@ -229,17 +214,10 @@
void PrintJob::UpdatePrintedDocument(PrintedDocument* new_document) {
if (document_.get() == new_document)
return;
- // Unregisters.
- if (document_.get()) {
- registrar_.Remove(this, NotificationType::PRINTED_DOCUMENT_UPDATED,
- Source<PrintedDocument>(document_.get()));
- }
+
document_ = new_document;
- // Registers.
if (document_.get()) {
- registrar_.Add(this, NotificationType::PRINTED_DOCUMENT_UPDATED,
- Source<PrintedDocument>(document_.get()));
settings_ = document_->settings();
}
« no previous file with comments | « chrome/browser/browser_main.cc ('k') | chrome/browser/printing/print_job_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698