Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 149148: Remove unused notification in print code to simplify before refactoring.... (Closed)

Created:
11 years, 5 months ago by Sverrir
Modified:
9 years, 7 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google), Mohamed Mansour
Visibility:
Public.

Description

Remove unused notification in print code to simplify before refactoring. Removed the PRINTED_DOCUMENT_UPDATED notification and move the debug output from PrintJobManager to PrintedDocument. Also made the --debug-print startup parameter only active in non-official builds. BUG=none TEST=Should have no functional affect. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19907

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -118 lines) Patch
M chrome/browser/browser_main.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/printing/print_job.cc View 2 chunks +1 line, -23 lines 0 comments Download
M chrome/browser/printing/print_job_manager.h View 3 chunks +0 lines, -23 lines 0 comments Download
M chrome/browser/printing/print_job_manager.cc View 4 chunks +1 line, -33 lines 0 comments Download
M chrome/browser/printing/printed_document.h View 1 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/printing/printed_document.cc View 1 4 chunks +57 lines, -21 lines 0 comments Download
M chrome/browser/printing/win_printing_context.cc View 2 chunks +2 lines, -9 lines 0 comments Download
M chrome/common/notification_type.h View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Sverrir
Step 1 of many for the printing refactoring (moving print related stuff out of browser ...
11 years, 5 months ago (2009-07-02 21:28:23 UTC) #1
M-A Ruel
http://codereview.chromium.org/149148/diff/1/4 File chrome/browser/printing/print_job.cc (left): http://codereview.chromium.org/149148/diff/1/4#oldcode233 Line 233: if (document_.get()) { You removed the notification registration ...
11 years, 5 months ago (2009-07-03 00:05:43 UTC) #2
Sverrir
http://codereview.chromium.org/149148/diff/1/4 File chrome/browser/printing/print_job.cc (left): http://codereview.chromium.org/149148/diff/1/4#oldcode233 Line 233: if (document_.get()) { On 2009/07/03 00:05:43, Marc-Antoine Ruel ...
11 years, 5 months ago (2009-07-03 14:08:51 UTC) #3
M-A Ruel
11 years, 5 months ago (2009-07-03 15:05:10 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698