Issue 149146: linux: fix a layout test by having our test plugin provide two mimetypes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149146: linux: fix a layout test by having our test plugin provide two mimetypes (Closed)

Created:
11 years, 5 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
Antoine Labour, jam

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

linux: fix a layout test by having our test plugin provide two mimetypes The layout test LayoutTests/fast/js/navigator-mimeTypes-length.html asserts that the number of mimetypes handled by plugins should be greater than the number of plugins. This isn't true if the layout test plugin is the only plugin and it only handles one mimetype, so we make it handle an additional fake mimetype.

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -4 lines)			Patch
	M	webkit/tools/layout_tests/test_expectations.txt	View		1 chunk	+0 lines, -3 lines	0 comments	Download
	M	webkit/tools/npapi_layout_test_plugin/main.cpp	View		1 chunk	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

On 2009/07/02 21:14:35, John Abd-El-Malek wrote: > why not just fix the test to be ...

11 years, 5 months ago (2009-07-02 21:39:40 UTC) #3

lgtm

Expand Messages | Collapse Messages