Issue 149145: Add remaining functionality for popup blocker: popup menu to unblock individu...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149145: Add remaining functionality for popup blocker: popup menu to unblock individu... (Closed)

Created:
11 years, 5 months ago by pink (ping after 24hrs)

Modified:
9 years, 7 months ago

Reviewers:
rohitrao (ping after 24h)

CC:
chromium-reviews_googlegroups.com, John Grabowski, Ben Goodger (Google)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Add remaining functionality for popup blocker: popup menu to unblock individual popups and whitelist sites. Also fixes intermittant leak on valgrind bots from poorly constructed unit test. BUG=13160, 15818 TEST=unblocking popups, whitelisting sites, and unwhitelisting them. Green valgrind bot. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19944

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+181 lines, -20 lines)			Patch
M	chrome/browser/blocked_popup_container.h	View		2 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/blocked_popup_container.cc	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/blocked_popup_container_controller.h	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/cocoa/blocked_popup_container_controller.mm	View	1	4 chunks	+135 lines, -12 lines	0 comments	Download
M	chrome/browser/cocoa/blocked_popup_container_controller_unittest.mm	View	1	4 chunks	+26 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

rohitrao (ping after 24h)

11 years, 5 months ago (2009-07-03 20:44:35 UTC) #2

LGTM

http://codereview.chromium.org/149145/diff/1/4
File chrome/browser/cocoa/blocked_popup_container_controller.mm (right):

http://codereview.chromium.org/149145/diff/1/4#newcode161
Line 161: #if 0
This is still supposed to be ifdefed out?

Expand Messages | Collapse Messages