Issue 149143: Fix showModalDialog regression.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149143: Fix showModalDialog regression. (Closed)

Created:
11 years, 5 months ago by jam

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews_googlegroups.com, darin (slow to review), brettw, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix showModalDialog regression. BUG=4202 TEST=added regression test. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19872

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -1 line)			Patch
M	chrome/browser/browser_uitest.cc	View	1	2 chunks	+25 lines, -0 lines	0 comments	Download
M	chrome/browser/renderer_host/render_view_host.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
A	chrome/test/data/showmodaldialog.html	View		1 chunk	+9 lines, -0 lines	0 comments	Download
A	chrome/test/data/showmodaldialog_dialog.html	View		1 chunk	+5 lines, -0 lines	0 comments	Download
A	chrome/test/data/showmodaldialog_dialog.js	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jam

11 years, 5 months ago (2009-07-02 23:16:17 UTC) #3

BTW I've disabled this test on mac and linux, and created a bug to track this
feature on those platforms:
http://code.google.com/p/chromium/issues/detail?id=15891

I doubt it ever worked there, since it's been broken in Windows since January.

Expand Messages | Collapse Messages