Issue 149140: Have the ApplyEdit* bookmark utilities return the BookmarkNode pointer...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149140: Have the ApplyEdit* bookmark utilities return the BookmarkNode pointer... (Closed)

Created:
11 years, 5 months ago by tim (not reviewing)

Modified:
9 years, 6 months ago

Reviewers:
ncarter (slow)

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Have the ApplyEdit* bookmark utilities return the BookmarkNode pointer so that callers know whether or not the original BookmarkNode* passed in is still valid or not. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19999

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -37 lines)			Patch
	M	chrome/browser/bookmarks/bookmark_utils.h	View	1 2	1 chunk	+20 lines, -14 lines	0 comments	Download
	M	chrome/browser/bookmarks/bookmark_utils.cc	View		3 chunks	+22 lines, -23 lines	0 comments	Download

Total messages: 2 (0 generated)

LGTM