Initial support for Linux installers. Currently just an amd64 .deb, but more ...

Initial support for Linux installers. Currently just an amd64 .deb, but more later.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20051

[Antoine Labour, 2009-07-06 23:32:49]

http://codereview.chromium.org/149132/diff/1/3
File installer/linux/build.scons (right):

http://codereview.chromium.org/149132/diff/1/3#newcode43
Line 43: return subprocess.Popen(command, shell=True, stdout=subprocess.PIPE). \
nit: I'd rather see a temporary variable than a \, e.g.
process = subprocess.Popen(command, shell=True, stdout=subprocess.PIPE)
return process.communicate()[0].strip()

http://codereview.chromium.org/149132/diff/1/3#newcode143
Line 143: output_dir='$ARTIFACTS_DIR')
What happens on 32-bit machines if dpkg-buildpackage is present ?

[Tristan Schmelcher, 2009-07-06 23:50:45]

http://codereview.chromium.org/149132/diff/1/3
File installer/linux/build.scons (right):

http://codereview.chromium.org/149132/diff/1/3#newcode43
Line 43: return subprocess.Popen(command, shell=True, stdout=subprocess.PIPE). \
On 2009/07/06 23:32:50, Antoine Labour wrote:
> nit: I'd rather see a temporary variable than a \, e.g.
> process = subprocess.Popen(command, shell=True, stdout=subprocess.PIPE)
> return process.communicate()[0].strip()

Done.

http://codereview.chromium.org/149132/diff/1/3#newcode143
Line 143: output_dir='$ARTIFACTS_DIR')
On 2009/07/06 23:32:50, Antoine Labour wrote:
> What happens on 32-bit machines if dpkg-buildpackage is present ?

I think in principle it should build an amd64 package just like this does on
64-bit machines, but I'll check to make sure.

[Antoine Labour, 2009-07-06 23:55:53]

LGTM if the installer rules don't cause issues on 32-bit machines.

[Tristan Schmelcher, 2009-07-07 18:25:22]

Added -aamd64 to the dpkg-buildpackage command line so that it works on 32-bit
machines too. Going to submit now.