In preparation for becoming an internal plugin in chrome I did these things:...

In preparation for becoming an internal plugin in chrome I did these things:
- Move declarations in the global namespace into the o3d namespace to avoid conflicts with Chrome.
- Ifdef out code that we do not want to run as an internal plugin (like breakpad, DllMain, etc)
- Prevent NP_Initialize, etc from being exported as an internal plugin.

Unfortunately I had to move functions around to group them by namespace so the diffs look like there is more change than there actually is.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20285

[vangelis, 2009-07-09 02:14:11]

diff doesn't handle large code moves very well so it's hard to see how much of
the changed code is now and how much of it has just been relocated a few lines
down.  I trust the copied code hasn't been modified....

LGTM

http://codereview.chromium.org/149130/diff/1031/60
File plugin/cross/blacklist.cc (right):

http://codereview.chromium.org/149130/diff/1031/60#newcode73
Line 73: }  // namesapce o3d
typo: namespace

http://codereview.chromium.org/149130/diff/1031/56
File plugin/mac/main_mac.mm (right):

http://codereview.chromium.org/149130/diff/1031/56#newcode821
Line 821: 
g_logging_initialized won't be defined if defined(O3D_INTERNAL_PLUGIN)

[Antoine Labour, 2009-07-11 02:59:43]

http://codereview.chromium.org/149130/diff/1031/62
File plugin/cross/main.cc (right):

http://codereview.chromium.org/149130/diff/1031/62#newcode49
Line 49: char *NP_GetMIMEDescription(void) {
FYI, that broke the linux plugin.
That's one of the necessary entry point on linux.