Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Issue 149127: Another batrch of performance improvements for NNTP... (Closed)

Created:
11 years, 5 months ago by arv (Not doing code reviews)
Modified:
9 years, 4 months ago
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

Another batch of performance improvements for NNTP. Hard code the DOM and the layout for the default case so that we do not need to do any js layout at startup. Be more careful when calling layout. I added a dirty bit so that we don't layout too often. CSS cleanup/optimization to make selectors faster. TEST=Run the perf test BUG=13362 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19877

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+292 lines, -151 lines) Patch
M chrome/browser/resources/new_new_tab.css View 12 chunks +22 lines, -18 lines 0 comments Download
M chrome/browser/resources/new_new_tab.html View 3 chunks +115 lines, -2 lines 0 comments Download
M chrome/browser/resources/new_new_tab.js View 15 chunks +155 lines, -131 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
arv (Not doing code reviews)
11 years, 5 months ago (2009-07-02 19:13:01 UTC) #1
Miranda Callahan
LGTM, but should wait for Glen, for his Javascript expertise. On 2009/07/02 19:13:01, arv wrote: ...
11 years, 5 months ago (2009-07-02 19:59:24 UTC) #2
arv (Not doing code reviews)
Here are the results from running NewTabUIStartupTest.PerfCold *RESULT new_tab: tab_cold= [244.00,223.00,231.00,228.00,205.00,] ms *RESULT new_tab: tab_cold= ...
11 years, 5 months ago (2009-07-02 20:40:16 UTC) #3
Glen Murphy
11 years, 5 months ago (2009-07-02 22:40:25 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698