Modify ThumbnailStore to make one call to the HistoryBackend using QueryTopUR...

Modify ThumbnailStore to make one call to the HistoryBackend using QueryTopURLsAndRedirects instead of a seperate call for each URL.  Also clean up some of the code and fix bug 14644.

BUG=14644
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19879

[meelapshah, 2009-07-02 19:18:57]

This has all the basic functionality.  The only remaining issue that I can think
of is the case when the history is cleared, pages are visited, and the new tab
page is opened before the timer triggers UpdateURLData. In this case the new tab
page will request thumbnails which we have but cannot find because we do not yet
have the redirect information.

It seems that we can't package the redirect information with the
HISTORY_URL_VISITED notification because of the pagecycler issue.

[brettw, 2009-07-02 22:26:54]

LGTM

http://codereview.chromium.org/149126/diff/12/14
File chrome/browser/thumbnail_store.cc (right):

http://codereview.chromium.org/149126/diff/12/14#newcode47
Line 47: &ThumbnailStore::UpdateURLData);
Didn't notice it before: this should be indented to the ( on the previous line.

[meelapshah, 2009-07-02 22:33:27]

http://codereview.chromium.org/149126/diff/12/14
File chrome/browser/thumbnail_store.cc (right):

http://codereview.chromium.org/149126/diff/12/14#newcode47
Line 47: &ThumbnailStore::UpdateURLData);
On 2009/07/02 22:26:54, brettw wrote:
> Didn't notice it before: this should be indented to the ( on the previous
line.

Done.

[meelapshah, 2009-07-03 00:49:33]

On 2009/07/02 22:33:27, meelapshah wrote:
> http://codereview.chromium.org/149126/diff/12/14
> File chrome/browser/thumbnail_store.cc (right):
> 
> http://codereview.chromium.org/149126/diff/12/14#newcode47
> Line 47: &ThumbnailStore::UpdateURLData);
> On 2009/07/02 22:26:54, brettw wrote:
> > Didn't notice it before: this should be indented to the ( on the previous
> line.
> 
> Done.

committed in 19879.