Issue 149101: Add an example of cancelling fullscreen mode to the fullscreen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149101: Add an example of cancelling fullscreen mode to the fullscreen. (Closed)

Created:
11 years, 6 months ago by Eric U.

Modified:
9 years, 7 months ago

Reviewers:
vangelis

CC:
o3d-review_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/o3d/

Visibility:
Public.

Description

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19574

Patch Set 2 : Update patch to include an onunload in the unlikely event that it's necessary #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -0 lines)			Patch
	M	samples/fullscreen.html	View	1	4 chunks	+32 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

vangelis

Minor point, otherwise LGTM http://codereview.chromium.org/149101/diff/1/2 File samples/fullscreen.html (right): http://codereview.chromium.org/149101/diff/1/2#newcode330 Line 330: clearTimeout(timeoutId); do we need ...

11 years, 6 months ago (2009-06-26 22:40:33 UTC) #2

LGTM

Expand Messages | Collapse Messages

Issue 149101: Add an example of cancelling fullscreen mode to the fullscreen. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Update patch to include an onunload in the unlikely event that it's necessary #

Messages