Issue 149100: Makes enter/shift-enter find next/previous on Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149100: Makes enter/shift-enter find next/previous on Mac. (Closed)

Created:
11 years, 6 months ago by rohitrao (ping after 24h)

Modified:
9 years, 7 months ago

Reviewers:
pink (ping after 24hrs)

CC:
chromium-reviews_googlegroups.com

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Makes enter/shift-enter find next/previous on Mac. BUG=htp://crbug.com/14890 TEST=Cmd-F to find in page. Type a word into the box, then ensure that pressing Enter finds the next instance, Shift-Enter finds the previous instance. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20996

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 2

Patch Set 5 : '' #

Patch Set 6 : '' #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -0 lines)			Patch
	M	chrome/browser/cocoa/find_bar_cocoa_controller.mm	View	3 4 5	1 chunk	+19 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

rohitrao (ping after 24h)

Is this a reasonable way of handling enter/shift-enter? I tried just adding key equivalents to ...

11 years, 5 months ago (2009-07-17 19:17:02 UTC) #1

pink (ping after 24hrs)

11 years, 5 months ago (2009-07-17 19:32:10 UTC) #2

LGTM with nits

http://codereview.chromium.org/149100/diff/4001/4002
File chrome/browser/cocoa/find_bar_cocoa_controller.mm (right):

http://codereview.chromium.org/149100/diff/4001/4002#newcode102
Line 102: doCommandBySelector:(SEL)command {
if you can't line up the colons, don't worry about it. THe higher order bit is
that the params are each indented at least 4 spaces (we recently changed the
style guide to clarify that).

http://codereview.chromium.org/149100/diff/4001/4002#newcode104
Line 104: //LOG(ERROR) << "control:textView:doCommandBySelector";
remove log

Expand Messages | Collapse Messages