Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 149096: Fix CheckSvnProperty canned check. (Closed)

Created:
11 years, 6 months ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
Jói Sigurðsson
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix CheckSvnProperty canned check. It was totally broken until I actually tried it. Fix the test accordingly. TEST=unit test BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19433

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -19 lines) Patch
M presubmit_canned_checks.py View 1 chunk +13 lines, -11 lines 0 comments Download
M tests/presubmit_unittest.py View 1 chunk +13 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
M-A Ruel
11 years, 6 months ago (2009-06-26 19:49:17 UTC) #1
Jói Sigurðsson
11 years, 6 months ago (2009-06-26 20:42:26 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698