Issue 14908: Change build-related files to use Windows SDK 6.1 instead of Windows SDK 6.0....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14908: Change build-related files to use Windows SDK 6.1 instead of Windows SDK 6.0.... (Closed)

Created:
12 years ago by jungshik at Google

Modified:
9 years, 7 months ago

Reviewers:
Nicolas Sylvain, nsylvain, M-A Ruel, sgk

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Change build-related files to use Windows SDK 6.1 instead of Windows SDK 6.0. SDK upgrade is necessary to support dynamic/webfont because SDK 6.0 does not have t2embapi.h and t2embed.lib. SDK 6.1 is compatible with WIn XP and VS 2005 or later. FYI: http://codereview.chromium.org/14084/show is the CL for adding web/dynamic font support. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7500

Patch Set 1 #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -12 lines)			Patch
M	build/SConscript.main	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	build/internal/essential.scons	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	build/internal/essential.vsprops	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/app/chrome.dll.deps	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sandbox/wow_helper/wow_helper.vcproj	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tools/memory_watcher/scripts/memtrace.pl	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/purify/purify_message.py	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

LGTM but: - You need to warn folks that this requires a full clobber. - ...

12 years ago (2008-12-19 23:10:02 UTC) #2

OK

Expand Messages | Collapse Messages