Issue 149068: - Inlined the code for make simple cons strings....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149068: - Inlined the code for make simple cons strings.... (Closed)

Created:
11 years, 5 months ago by bak

Modified:
9 years, 7 months ago

Reviewers:
Kasper Lund, kasperl

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

- Inlined the code for make simple cons strings. - Simplify generated code for Runtime_** functions. Committed: http://code.google.com/p/v8/source/detail?r=2283

Patch Set 1 #

Total comments: 2

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -29 lines)			Patch
M	src/factory.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/heap.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/heap.cc	View	2 chunks	+18 lines, -4 lines	2 comments	Download
M	src/runtime.cc	View	4 chunks	+3 lines, -21 lines	0 comments	Download
M	src/top.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/top.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kasper Lund

11 years, 5 months ago (2009-06-26 13:07:23 UTC) #2

LGTM!

http://codereview.chromium.org/149068/diff/1/2
File src/heap.cc (right):

http://codereview.chromium.org/149068/diff/1/2#newcode1567
Line 1567: char* src  = SeqAsciiString::cast(first)->GetChars();
Remove extra space after src

http://codereview.chromium.org/149068/diff/1/2#newcode1570
Line 1570: src  = SeqAsciiString::cast(second)->GetChars();
Remove extra space after src.

Expand Messages | Collapse Messages