Issue 149066: X64 Implementation: Correct type, add VisitCallEval

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149066: X64 Implementation: Correct type, add VisitCallEval (Closed)

Created:
11 years, 6 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

X64 Implementation: Correct type, add VisitCallEval Committed: http://code.google.com/p/v8/source/detail?r=2282

Patch Set 2 : '' #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+115 lines, -56 lines)			Patch
	M	src/objects.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	src/x64/codegen-x64.cc	View	1	8 chunks	+112 lines, -56 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

LGTM http://codereview.chromium.org/149066/diff/1/2 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/149066/diff/1/2#newcode2547 Line 2547: __ movl(scratch.reg(), FieldOperand(result.reg(), FixedArray::kHeaderSize)); Comment or name ...

11 years, 6 months ago (2009-06-26 11:15:41 UTC) #2

William Hesse

11 years, 6 months ago (2009-06-26 11:57:31 UTC) #3

http://codereview.chromium.org/149066/diff/1/2
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/149066/diff/1/2#newcode2547
Line 2547: __ movl(scratch.reg(), FieldOperand(result.reg(),
FixedArray::kHeaderSize));
On 2009/06/26 11:15:41, Lasse Reichstein wrote:
> Comment or name offset as first element of fixed array.

Done.

http://codereview.chromium.org/149066/diff/1/2#newcode2553
Line 2553: FieldOperand(result.reg(), FixedArray::kHeaderSize + kPointerSize));
On 2009/06/26 11:15:41, Lasse Reichstein wrote:
> Indentation.
> Give the offset a name like kFixedArraySecondElementOffset.
> 

Done.

Expand Messages | Collapse Messages

Issue 149066: X64 Implementation: Correct type, add VisitCallEval (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages