Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 149065: Implement Linux sys_string_conversions using the system APIs. (Closed)

Created:
11 years, 6 months ago by Dean McNamee
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Implement Linux sys_string_conversions using the system APIs. BUG=14826

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+250 lines, -4 lines) Patch
M base/sys_string_conversions_linux.cc View 2 chunks +113 lines, -4 lines 2 comments Download
M base/sys_string_conversions_unittest.cc View 2 chunks +137 lines, -0 lines 2 comments Download

Messages

Total messages: 3 (0 generated)
Dean McNamee
TBR Retrying, and added a ScopedSetLocale.
11 years, 6 months ago (2009-06-26 09:54:01 UTC) #1
Evan Martin
LGTM http://codereview.chromium.org/149065/diff/1/2 File base/sys_string_conversions_linux.cc (right): http://codereview.chromium.org/149065/diff/1/2#newcode88 Line 88: mbstate_t ps; Style frowns upon abbreviated variable ...
11 years, 6 months ago (2009-06-26 15:19:26 UTC) #2
Dean McNamee
11 years, 6 months ago (2009-06-26 15:23:07 UTC) #3
http://codereview.chromium.org/149065/diff/1/2
File base/sys_string_conversions_linux.cc (right):

http://codereview.chromium.org/149065/diff/1/2#newcode88
Line 88: mbstate_t ps;
On 2009/06/26 15:19:26, Evan Martin wrote:
> Style frowns upon abbreviated variable names.  "mbstate" woulda worked.

Yeah, that's the style they give in the man page so I just copied it.  You're
probably right though.

http://codereview.chromium.org/149065/diff/1/3
File base/sys_string_conversions_unittest.cc (right):

http://codereview.chromium.org/149065/diff/1/3#newcode190
Line 190: // We assume our test is running in UTF-8, so double check through
ICU.
On 2009/06/26 15:19:26, Evan Martin wrote:
> This comment is obsolete because you've ensured it now.

The comment isn't obsolete.  The point was we can use ICU's UTF8 implementation
to double-check our code.

Powered by Google App Engine
This is Rietveld 408576698