Issue 149008: X64 Implementation: Correct error with initializer blocks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149008: X64 Implementation: Correct error with initializer blocks (Closed)

Created:
11 years, 6 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

X64 Implementation: Correct error with initializer blocks Committed: http://code.google.com/p/v8/source/detail?r=2276

Patch Set 2 : '' #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -9 lines)			Patch
	M	src/x64/codegen-x64.cc	View	1	5 chunks	+7 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

LGTM http://codereview.chromium.org/149008/diff/1/2 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/149008/diff/1/2#newcode3262 Line 3262: __ cmpq(result.reg(), Immediate(0)); Could this be a ...

11 years, 6 months ago (2009-06-25 17:41:30 UTC) #2

William Hesse

11 years, 6 months ago (2009-06-26 07:27:05 UTC) #3

http://codereview.chromium.org/149008/diff/1/2
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/149008/diff/1/2#newcode3262
Line 3262: __ cmpq(result.reg(), Immediate(0));
On 2009/06/25 17:41:30, Lasse Reichstein wrote:
> Could this be a register self-test too?

Done.

Expand Messages | Collapse Messages

Issue 149008: X64 Implementation: Correct error with initializer blocks (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages