Issue 149005: X64: Added for-in

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149005: X64: Added for-in (Closed)

Created:
11 years, 6 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
William Hesse

CC:
v8-dev

Visibility:
Public.

Description

X64: Added for-in

Patch Set 1 #

Total comments: 2

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+212 lines, -2 lines)			Patch
	M	src/x64/codegen-x64.cc	View		3 chunks	+212 lines, -2 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

William Hesse

11 years, 6 months ago (2009-06-25 22:39:10 UTC) #2

LGTM.

http://codereview.chromium.org/149005/diff/1/2
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/149005/diff/1/2#newcode1075
Line 1075: __ cmpq(rcx, Immediate(FIRST_JS_OBJECT_TYPE));
Why not CmpObjectType macro?  Or why not movb and cmpb?
BTW, for cmpb we want above and below, for unsigned byte compares, as you have
here.

http://codereview.chromium.org/149005/diff/1/2#newcode1208
Line 1208: node->continue_target()->Bind();
// TODO(make an issue?) Consider making a SpilledTarget jump target type, that
spills all frames jumping to it.  Only if it might be useful for other jumps to
just before a call, for example.

Expand Messages | Collapse Messages