Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 149003: Fix instance type check in apply optimization.... (Closed)

Created:
11 years, 6 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
Reviewers:
Kasper Lund
CC:
v8-dev
Visibility:
Public.

Description

Fix instance type check in apply optimization. We accidentally compared a map address with an instance type. This fix additionally avoids an upper bounds check that is not needed. Committed: http://code.google.com/p/v8/source/detail?r=2272

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M src/ia32/codegen-ia32.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M test/mjsunit/arguments-apply.js View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (chromium)
11 years, 6 months ago (2009-06-25 11:18:13 UTC) #1
Kasper Lund
11 years, 6 months ago (2009-06-25 11:33:59 UTC) #2
STV.

Powered by Google App Engine
This is Rietveld 408576698