Issue 149002: X64: Count operations (increment, decrement)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149002: X64: Count operations (increment, decrement) (Closed)

Created:
11 years, 6 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
William Hesse

CC:
v8-dev

Visibility:
Public.

Description

X64: Count operations (increment, decrement)

Patch Set 1 #

Total comments: 3

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+269 lines, -4 lines)			Patch
M	src/x64/assembler-x64.h	View	1 chunk	+0 lines, -2 lines	1 comment	Download
M	src/x64/codegen-x64.cc	View	2 chunks	+217 lines, -2 lines	1 comment	Download
M	src/x64/register-allocator-x64.cc	View	1 chunk	+13 lines, -0 lines	1 comment	Download
M	src/x64/virtual-frame-x64.cc	View	1 chunk	+39 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

William Hesse

11 years, 6 months ago (2009-06-25 10:46:05 UTC) #2

LGTM, with comments addressed.

http://codereview.chromium.org/149002/diff/1/2
File src/x64/assembler-x64.h (left):

http://codereview.chromium.org/149002/diff/1/2#oldcode85
Line 85: // The byte-register distinction of ai32 has dissapeared.
ia32

http://codereview.chromium.org/149002/diff/1/3
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/149002/diff/1/3#newcode1726
Line 1726: Result tmp = allocator_->AllocateWithoutSpilling();
The allocation and use of tmp can be replaced with kScratchRegister.  There is
no more byte register distinction anyway.  We also drop the else case (test
separately).

http://codereview.chromium.org/149002/diff/1/4
File src/x64/register-allocator-x64.cc (right):

http://codereview.chromium.org/149002/diff/1/4#newcode80
Line 80: // AL, CL, DL or BL, the REX.W bit is necessary to trigger 64-bit
We really don't even need this function anymore.  It is misleading, at best.

Expand Messages | Collapse Messages