Issue 14900: Remove base dependencies in the Windows-specific skia/ext code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14900: Remove base dependencies in the Windows-specific skia/ext code. (Closed)

Created:
12 years ago by brettw

Modified:
9 years, 7 months ago

Reviewers:
dglazkov

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Remove base dependencies in the Windows-specific skia/ext code. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7317

Patch Set 1 #

Total comments: 3

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+162 lines, -134 lines)			Patch
M	skia/ext/bitmap_platform_device_win.h	View	4 chunks	+8 lines, -8 lines	0 comments	Download
M	skia/ext/bitmap_platform_device_win.cc	View	14 chunks	+41 lines, -25 lines	1 comment	Download
M	skia/ext/platform_canvas_win.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	skia/ext/platform_canvas_win.cc	View	4 chunks	+12 lines, -10 lines	0 comments	Download
M	skia/ext/platform_device_win.cc	View	8 chunks	+20 lines, -22 lines	0 comments	Download
M	skia/ext/skia_utils_win.cc	View	2 chunks	+15 lines, -6 lines	0 comments	Download
M	skia/ext/vector_canvas.h	View	1 chunk	+3 lines, -1 line	1 comment	Download
M	skia/ext/vector_canvas.cc	View	4 chunks	+6 lines, -6 lines	0 comments	Download
M	skia/ext/vector_device.h	View	2 chunks	+6 lines, -5 lines	1 comment	Download
M	skia/ext/vector_device.cc	View	30 chunks	+51 lines, -50 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

dglazkov

12 years ago (2008-12-19 20:46:41 UTC) #2

LGTM, with a few comments:

http://codereview.chromium.org/14900/diff/1/3
File skia/ext/bitmap_platform_device_win.cc (right):

http://codereview.chromium.org/14900/diff/1/3#newcode150
Line 150: };
Already is a sub-class of SkNonCopyable, right?

http://codereview.chromium.org/14900/diff/1/6
File skia/ext/vector_canvas.h (right):

http://codereview.chromium.org/14900/diff/1/6#newcode43
Line 43: };
It's already a sub-class of SkNonCopyable -- do we need these extra defs?

http://codereview.chromium.org/14900/diff/1/10
File skia/ext/vector_device.h (right):

http://codereview.chromium.org/14900/diff/1/10#newcode115
Line 115: };
Ditto here?

Expand Messages | Collapse Messages