Issue 14868: Add the CertVerifier class. It is based on the...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14868: Add the CertVerifier class. It is based on the... (Closed)

Created:
12 years ago by wtc

Modified:
9 years, 7 months ago

Reviewers:
eroman

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add the CertVerifier class. It is based on the HostResolver class. It's not being compiled yet. R=eroman BUG=3592 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7280

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+86 lines, -159 lines)			Patch
A +	net/base/cert_verifier.h	View	1 2	2 chunks	+31 lines, -50 lines	0 comments	Download
A +	net/base/cert_verifier.cc	View		3 chunks	+52 lines, -106 lines	0 comments	Download
M	net/base/host_resolver.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

eroman

12 years ago (2008-12-19 00:05:56 UTC) #2

LGTM. I will review this more thoroughly once I see how it is used.

http://codereview.chromium.org/14868/diff/203/6
File net/base/cert_verifier.h (right):

http://codereview.chromium.org/14868/diff/203/6#newcode42
Line 42: // If rev_checking_enabled is true, certificate revocation checking is
|rev_checking_enabled| to be consistent with elsewhere.

Expand Messages | Collapse Messages