Issue 14861: Move various gtest-style unit tests out of webkit/port and into a new...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14861: Move various gtest-style unit tests out of webkit/port and into a new... (Closed)

Created:
12 years ago by darin (slow to review)

Modified:
9 years, 7 months ago

Reviewers:
dglazkov

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Move various gtest-style unit tests out of webkit/port and into a new tools/webcore_unit_tests directory. I chose this directory because we have a bunch of similar "tests" directories inside webkit/tools. R=dglazkov Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7259

Patch Set 1 #

Patch Set 2 : '' #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -967 lines)			Patch
D	webkit/port/platform/GKURL_unittest.cpp	View		1 chunk	+0 lines, -600 lines	0 comments	Download
D	webkit/port/platform/graphics/chromium/UniscribeHelper_unittest.cpp	View		1 chunk	+0 lines, -142 lines	0 comments	Download
D	webkit/port/platform/image-decoders/bmp/BMPImageDecoder_unittest.cpp	View		1 chunk	+0 lines, -53 lines	0 comments	Download
D	webkit/port/platform/image-decoders/ico/ICOImageDecoder_unittest.cpp	View		1 chunk	+0 lines, -84 lines	0 comments	Download
D	webkit/port/platform/image-decoders/xbm/XBMImageDecoder_unittest.cpp	View		1 chunk	+0 lines, -53 lines	0 comments	Download
M	webkit/tools/test_shell/SConscript	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	webkit/tools/test_shell/mac/TestShell.xcodeproj/project.pbxproj	View	1	12 chunks	+28 lines, -25 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell_tests.vcproj	View		5 chunks	+5 lines, -5 lines	0 comments	Download
A	webkit/tools/webcore_unit_tests/README	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

dglazkov

12 years ago (2008-12-18 21:59:55 UTC) #2

LGTM, except Rietveld doesn't seem to show the files in new location?

Expand Messages | Collapse Messages