Issue 14836: Unroll + and ? to reduce loop-related work.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14836: Unroll + and ? to reduce loop-related work. (Closed)

Created:
12 years ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Unroll + and ? to reduce loop-related work. Committed: http://code.google.com/p/v8/source/detail?r=1003

Patch Set 1 #

Total comments: 3

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -0 lines)			Patch
	M	src/jsregexp.cc	View		1 chunk	+42 lines, -0 lines	3 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

12 years ago (2008-12-18 12:34:17 UTC) #2

LGTM

http://codereview.chromium.org/14836/diff/1/2
File src/jsregexp.cc (right):

http://codereview.chromium.org/14836/diff/1/2#newcode2710
Line 2710: if (min > 0 && min <= 3) {
static const int kMaxUnrollRepetition = 3;

http://codereview.chromium.org/14836/diff/1/2#newcode2716
Line 2716: // TextNodes (which the parser does not generate).
Will these chains of text nodes normalied at a later time?

http://codereview.chromium.org/14836/diff/1/2#newcode2722
Line 2722: if (max <= 3) {
Same constant, or another?

Expand Messages | Collapse Messages