src/codegen-ia32.cc - Issue 14834: Fixing a subtle bug in receiver resolution when a thrown and caught function ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/codegen-ia32.cc

Issue 14834: Fixing a subtle bug in receiver resolution when a thrown and caught function ... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: '' Created 12 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/codegen-ia32.cc

===================================================================

--- src/codegen-ia32.cc (revision 984)

+++ src/codegen-ia32.cc (working copy)

@@ -1584,7 +1584,11 @@

Comment cmnt(masm_, "[ WithEnterStatement");

RecordStatementPosition(node);

Load(node->expression());

- __ CallRuntime(Runtime::kPushContext, 1);

+ if (node->is_catch_block()) {

+ __ CallRuntime(Runtime::kPushCatchContext, 1);

+ } else {

+ __ CallRuntime(Runtime::kPushContext, 1);

+ }

if (kDebug) {

Label verified_true;

« no previous file with comments | « src/codegen-arm.cc ('k') | src/contexts.h » ('j') | no next file with comments »