Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1091)

Side by Side Diff: src/codegen-ia32.cc

Issue 14834: Fixing a subtle bug in receiver resolution when a thrown and caught function ... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 12 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/codegen-arm.cc ('k') | src/contexts.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1566 matching lines...) Expand 10 before | Expand all | Expand 10 after
1577 ASSERT_EQ(Debug::kIa32JSReturnSequenceLength, 1577 ASSERT_EQ(Debug::kIa32JSReturnSequenceLength,
1578 __ SizeOfCodeGeneratedSince(&check_exit_codesize)); 1578 __ SizeOfCodeGeneratedSince(&check_exit_codesize));
1579 } 1579 }
1580 } 1580 }
1581 1581
1582 1582
1583 void CodeGenerator::VisitWithEnterStatement(WithEnterStatement* node) { 1583 void CodeGenerator::VisitWithEnterStatement(WithEnterStatement* node) {
1584 Comment cmnt(masm_, "[ WithEnterStatement"); 1584 Comment cmnt(masm_, "[ WithEnterStatement");
1585 RecordStatementPosition(node); 1585 RecordStatementPosition(node);
1586 Load(node->expression()); 1586 Load(node->expression());
1587 __ CallRuntime(Runtime::kPushContext, 1); 1587 if (node->is_catch_block()) {
1588 __ CallRuntime(Runtime::kPushCatchContext, 1);
1589 } else {
1590 __ CallRuntime(Runtime::kPushContext, 1);
1591 }
1588 1592
1589 if (kDebug) { 1593 if (kDebug) {
1590 Label verified_true; 1594 Label verified_true;
1591 // Verify eax and esi are the same in debug mode 1595 // Verify eax and esi are the same in debug mode
1592 __ cmp(eax, Operand(esi)); 1596 __ cmp(eax, Operand(esi));
1593 __ j(equal, &verified_true); 1597 __ j(equal, &verified_true);
1594 __ int3(); 1598 __ int3();
1595 __ bind(&verified_true); 1599 __ bind(&verified_true);
1596 } 1600 }
1597 1601
(...skipping 3599 matching lines...) Expand 10 before | Expand all | Expand 10 after
5197 5201
5198 // Slow-case: Go through the JavaScript implementation. 5202 // Slow-case: Go through the JavaScript implementation.
5199 __ bind(&slow); 5203 __ bind(&slow);
5200 __ InvokeBuiltin(Builtins::INSTANCE_OF, JUMP_FUNCTION); 5204 __ InvokeBuiltin(Builtins::INSTANCE_OF, JUMP_FUNCTION);
5201 } 5205 }
5202 5206
5203 5207
5204 #undef __ 5208 #undef __
5205 5209
5206 } } // namespace v8::internal 5210 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/codegen-arm.cc ('k') | src/contexts.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698