Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Side by Side Diff: src/codegen-arm.cc

Issue 14834: Fixing a subtle bug in receiver resolution when a thrown and caught function ... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 12 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ast.h ('k') | src/codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1256 matching lines...) Expand 10 before | Expand all | Expand 10 after
1267 frame_->Pop(r0); 1267 frame_->Pop(r0);
1268 1268
1269 __ b(&function_return_); 1269 __ b(&function_return_);
1270 } 1270 }
1271 1271
1272 1272
1273 void CodeGenerator::VisitWithEnterStatement(WithEnterStatement* node) { 1273 void CodeGenerator::VisitWithEnterStatement(WithEnterStatement* node) {
1274 Comment cmnt(masm_, "[ WithEnterStatement"); 1274 Comment cmnt(masm_, "[ WithEnterStatement");
1275 if (FLAG_debug_info) RecordStatementPosition(node); 1275 if (FLAG_debug_info) RecordStatementPosition(node);
1276 Load(node->expression()); 1276 Load(node->expression());
1277 __ CallRuntime(Runtime::kPushContext, 1); 1277 if (node->is_catch_block()) {
1278 __ CallRuntime(Runtime::kPushCatchContext, 1);
1279 } else {
1280 __ CallRuntime(Runtime::kPushContext, 1);
1281 }
1278 if (kDebug) { 1282 if (kDebug) {
1279 Label verified_true; 1283 Label verified_true;
1280 __ cmp(r0, Operand(cp)); 1284 __ cmp(r0, Operand(cp));
1281 __ b(eq, &verified_true); 1285 __ b(eq, &verified_true);
1282 __ stop("PushContext: r0 is expected to be the same as cp"); 1286 __ stop("PushContext: r0 is expected to be the same as cp");
1283 __ bind(&verified_true); 1287 __ bind(&verified_true);
1284 } 1288 }
1285 // Update context local. 1289 // Update context local.
1286 __ str(cp, frame_->Context()); 1290 __ str(cp, frame_->Context());
1287 } 1291 }
(...skipping 3043 matching lines...) Expand 10 before | Expand all | Expand 10 after
4331 __ mov(r2, Operand(0)); 4335 __ mov(r2, Operand(0));
4332 __ GetBuiltinEntry(r3, Builtins::CALL_NON_FUNCTION); 4336 __ GetBuiltinEntry(r3, Builtins::CALL_NON_FUNCTION);
4333 __ Jump(Handle<Code>(Builtins::builtin(Builtins::ArgumentsAdaptorTrampoline)), 4337 __ Jump(Handle<Code>(Builtins::builtin(Builtins::ArgumentsAdaptorTrampoline)),
4334 RelocInfo::CODE_TARGET); 4338 RelocInfo::CODE_TARGET);
4335 } 4339 }
4336 4340
4337 4341
4338 #undef __ 4342 #undef __
4339 4343
4340 } } // namespace v8::internal 4344 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ast.h ('k') | src/codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698