Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 14834: Fixing a subtle bug in receiver resolution when a thrown and caught function ... (Closed)

Created:
12 years ago by olehougaard
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fixing a subtle bug in receiver resolution when a thrown and caught function is called from a catch-block. Second attempt - now with better memory efficiency. Committed: http://code.google.com/p/v8/source/detail?r=999

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -32 lines) Patch
M src/ast.h View 1 chunk +5 lines, -2 lines 0 comments Download
M src/codegen-arm.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/codegen-ia32.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/contexts.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/factory.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/factory.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M src/heap.h View 2 chunks +4 lines, -1 line 0 comments Download
M src/heap.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects-inl.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/parser.cc View 5 chunks +11 lines, -5 lines 0 comments Download
M src/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime.cc View 1 4 chunks +37 lines, -17 lines 0 comments Download
A test/mjsunit/throw-and-catch-function.js View 1 1 chunk +50 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
olehougaard
12 years ago (2008-12-18 09:42:27 UTC) #1
Mads Ager (chromium)
Overall, this looks like the right approach. Adding another field to all contexts seems like ...
12 years ago (2008-12-18 10:00:32 UTC) #2
Mads Ager (chromium)
Does this work if you assign to the catch variable inside of the catch block? ...
12 years ago (2008-12-18 10:10:29 UTC) #3
olehougaard
12 years ago (2008-12-18 10:39:33 UTC) #4
Mads Ager (chromium)
12 years ago (2008-12-18 10:45:22 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698