Issue 14827: Implement FilePath::Contains()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14827: Implement FilePath::Contains() (Closed)

Created:
12 years ago by Aaron Boodman

Modified:
9 years, 6 months ago

Reviewers:
DO NOT USE THIS ACCOUNT, Erik does not do reviews

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Rather than create a TODO that will never be done, I went ahead and implemented FilePath::Contains().

Patch Set 1 #

Patch Set 2 : fixens #

Patch Set 3 : Make it work on posix blargh #

Total comments: 1

Patch Set 4 : Make it work on mac and linux #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+96 lines, -6 lines)			Patch
M	base/file_path.h	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
M	base/file_path.cc	View	1 2 3	2 chunks	+27 lines, -0 lines	0 comments	Download
M	base/file_path_unittest.cc	View	1 2 3	6 chunks	+64 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

DO NOT USE THIS ACCOUNT

12 years ago (2008-12-18 04:29:44 UTC) #2

LGTM - excellent!

http://codereview.chromium.org/14827/diff/203/13
File base/file_path.cc (right):

http://codereview.chromium.org/14827/diff/203/13#newcode199
Line 199: // file_util::AbsolutePath() normalizes '/' to '\', so we only need to
check
on windows

Expand Messages | Collapse Messages