Issue 14818: Fix Linux build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14818: Fix Linux build. (Closed)

Created:
12 years ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review), wtc

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Fix Linux build.

Patch Set 1 #

Total comments: 1

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	net/ftp/ftp_network_transaction.cc	View		2 chunks	+3 lines, -2 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

wtc

12 years ago (2008-12-17 23:54:03 UTC) #2

LGTM.

http://codereview.chromium.org/14818/diff/1/2
File net/ftp/ftp_network_transaction.cc (right):

http://codereview.chromium.org/14818/diff/1/2#newcode16
Line 16: :  ALLOW_THIS_IN_INITIALIZER_LIST(io_callback_(this,
Nit: the colon should be indented by 4.  And only
one space after the colon.

Expand Messages | Collapse Messages