Issue 14806: Fixes crash in download tab view that resulted from attempting to...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14806: Fixes crash in download tab view that resulted from attempting to... (Closed)

Created:
12 years ago by sky

Modified:
9 years, 7 months ago

Reviewers:
Paul Godavari

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fixes crash in download tab view that resulted from attempting to paint a download at downloads_.size(). This happened if the last download is visible, in which case row_stop == downloads_.size() and because the loop iterates to row_stop we try accessing downloads_[downloads_.size()]. BUG=5520 TEST=Bring up the downloads view and make sure you can scroll to the end of your downloads without crashing. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7161

Patch Set 1 #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	chrome/browser/views/download_tab_view.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages