Issue 14802: Correct typo in SDCH problem logging code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14802: Correct typo in SDCH problem logging code. (Closed)

Created:
12 years ago by jar (doing other things)

Modified:
9 years, 7 months ago

Reviewers:
huanr, Lincoln

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Correct typo in SDCH problem logging code. r=openvcdiff,huanr Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7162

Patch Set 3 : '' #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	net/base/sdch_manager.h	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
	M	net/base/sdch_manager.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Lincoln

LGTM http://codereview.chromium.org/14802/diff/6/8 File net/base/sdch_manager.h (right): http://codereview.chromium.org/14802/diff/6/8#newcode111 Line 111: PLEASE_IGNORE_THIS_ENUM = 60, // Erroneous use in ...

12 years ago (2008-12-17 19:24:13 UTC) #2

jar (doing other things)

12 years ago (2008-12-17 20:00:43 UTC) #4

change in comment per Lincoln's suggestion.

http://codereview.chromium.org/14802/diff/6/8
File net/base/sdch_manager.h (right):

http://codereview.chromium.org/14802/diff/6/8#newcode111
Line 111: PLEASE_IGNORE_THIS_ENUM = 60,  // Erroneous use in first OOB Chrome.
On 2008/12/17 19:24:13, Lincoln wrote:
> nit: Abbreviations like OOB may be incomprehensible to some readers.

I changed it to "Version 1 of Chrome"

Expand Messages | Collapse Messages

Issue 14802: Correct typo in SDCH problem logging code. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages