Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: chromeos/audio/audio_devices_pref_handler.h

Issue 14801002: Switch Audio Preferences to per device. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/audio/audio_devices_pref_handler.h
diff --git a/chromeos/audio/audio_pref_handler.h b/chromeos/audio/audio_devices_pref_handler.h
similarity index 60%
copy from chromeos/audio/audio_pref_handler.h
copy to chromeos/audio/audio_devices_pref_handler.h
index 08f38c0b0627f4be9f79b9e8df5f33c6e2b3524c..63e3ed746f679f57071bfa10978dcd5dff1f1198 100644
--- a/chromeos/audio/audio_pref_handler.h
+++ b/chromeos/audio/audio_devices_pref_handler.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROMEOS_AUDIO_AUDIO_PREF_HANDLER_H_
-#define CHROMEOS_AUDIO_AUDIO_PREF_HANDLER_H_
+#ifndef CHROMEOS_AUDIO_AUDIO_DEVICES_PREF_HANDLER_H_
+#define CHROMEOS_AUDIO_AUDIO_DEVICES_PREF_HANDLER_H_
#include "base/basictypes.h"
#include "base/memory/ref_counted.h"
@@ -17,43 +17,39 @@ namespace chromeos {
// Interface that handles audio preference related work, reads and writes
// audio preferences, and notifies AudioPrefObserver for audio preference
// changes.
-class CHROMEOS_EXPORT AudioPrefHandler
- : public base::RefCountedThreadSafe<AudioPrefHandler> {
+class CHROMEOS_EXPORT AudioDevicesPrefHandler
+ : public base::RefCountedThreadSafe<AudioDevicesPrefHandler> {
public:
- // Gets the audio output volume value from prefs.
+ // Gets the audio output volume value from prefs for the active device.
virtual double GetOutputVolumeValue() = 0;
-
- // Sets the output audio volume value to prefs.
- virtual void SetOutputVolumeValue(double volume_percent) = 0;
-
- // Reads the audio output mute value from prefs.
+ // Reads the audio output mute value from prefs for the active device.
virtual bool GetOutputMuteValue() = 0;
- // Sets the audio output mute value to prefs.
+ // Sets the output audio volume value to prefs for the active device.
+ virtual void SetOutputVolumeValue(double volume_percent) = 0;
+ // Sets the audio output mute value to prefs for the active device.
virtual void SetOutputMuteValue(bool mute_on) = 0;
// Reads the audio capture allowed value from prefs.
virtual bool GetAudioCaptureAllowedValue() = 0;
-
- // Sets the audio output allowed value from prefs.
+ // Reads the audio output allowed value from prefs.
virtual bool GetAudioOutputAllowedValue() = 0;
// Adds an audio preference observer.
virtual void AddAudioPrefObserver(AudioPrefObserver* observer) = 0;
-
// Removes an audio preference observer.
virtual void RemoveAudioPrefObserver(AudioPrefObserver* observer) = 0;
// Creates the instance.
- static AudioPrefHandler* Create(PrefService* local_state);
+ static AudioDevicesPrefHandler* Create(PrefService* local_state);
protected:
- virtual ~AudioPrefHandler() {}
+ virtual ~AudioDevicesPrefHandler() {}
private:
- friend class base::RefCountedThreadSafe<AudioPrefHandler>;
+ friend class base::RefCountedThreadSafe<AudioDevicesPrefHandler>;
};
} // namespace chromeos
-#endif // CHROMEOS_AUDIO_AUDIO_PREF_HANDLER_H_
+#endif // CHROMEOS_AUDIO_AUDIO_DEVICES_PREF_HANDLER_H_

Powered by Google App Engine
This is Rietveld 408576698