Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 1480002: GYP changes for FreeBSD and OpenBSD (Closed)

Created:
10 years, 9 months ago by Peter Valchev
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews, fbarchard, Alpha Left Google, Paweł Hajdan Jr., apatrick_chromium, darin-cc_chromium.org, awong, brettw-cc_chromium.org, kuchhal, scherkus (not reviewing), sprewell_jaggeri.com
Visibility:
Public.

Description

GYP changes for FreeBSD and OpenBSD Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47327

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -21 lines) Patch
M build/all.gyp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M build/linux/system.gyp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/common_constants.gypi View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/installer_util.gypi View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/third_party/nss/nss.gyp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M sandbox/sandbox.gyp View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M skia/skia.gyp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/bzip2/bzip2.gyp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/expat/expat.gyp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/ffmpeg/ffmpeg.gyp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/libjingle/libjingle.gyp View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/libjpeg/libjpeg.gyp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/libpng/libpng.gyp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/npapi/npapi.gyp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/sqlite/sqlite.gyp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/zlib/zlib.gyp View 1 2 1 chunk +2 lines, -2 lines 2 comments Download

Messages

Total messages: 9 (0 generated)
Peter Valchev
10 years, 9 months ago (2010-03-27 00:15:41 UTC) #1
Evan Martin
I hate to say it, but I really think we should rename the _linux files ...
10 years, 9 months ago (2010-03-27 00:21:57 UTC) #2
Evan Martin
10 years, 9 months ago (2010-03-27 00:22:04 UTC) #3
Peter Valchev
On 2010/03/27 00:21:57, Evan Martin wrote: > I hate to say it, but I really ...
10 years, 9 months ago (2010-03-30 04:10:51 UTC) #4
Evan Martin
I'm willing to do the necessary work to rename the files. Can you tell me ...
10 years, 8 months ago (2010-04-19 16:42:31 UTC) #5
Peter Valchev
Well, right now all _linux.cc files are built on *BSD, with the exception of like ...
10 years, 8 months ago (2010-04-19 21:20:52 UTC) #6
Peter Valchev
Evan, I removed all of the stuff that I think you found objectionable - the ...
10 years, 7 months ago (2010-05-14 20:39:54 UTC) #7
Evan Martin
LGTM either way http://codereview.chromium.org/1480002/diff/13001/14016 File third_party/zlib/zlib.gyp (right): http://codereview.chromium.org/1480002/diff/13001/14016#newcode8 third_party/zlib/zlib.gyp:8: [ 'OS=="linux" or OS=="freebsd"', { did ...
10 years, 7 months ago (2010-05-14 21:24:15 UTC) #8
Peter Valchev
10 years, 7 months ago (2010-05-14 21:41:21 UTC) #9
Thanks for the quick review!

http://codereview.chromium.org/1480002/diff/13001/14016
File third_party/zlib/zlib.gyp (right):

http://codereview.chromium.org/1480002/diff/13001/14016#newcode8
third_party/zlib/zlib.gyp:8: [ 'OS=="linux" or OS=="freebsd"', {
On 2010/05/14 21:24:17, Evan Martin wrote:
> did you mean to include openbsd here?

I purposefully did not, because using the system zlib broke the rendering on
OpenBSD - I don't know if you remember me asking you for debugging help a month
or so back :)

I'll add a comment.

Powered by Google App Engine
This is Rietveld 408576698