Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Unified Diff: webkit/glue/media/video_renderer_impl.cc

Issue 147225: Refactoring to introduce refcount to WebMediaPlayerImpl... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/glue/media/video_renderer_impl.h ('k') | webkit/glue/webmediaplayer_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/media/video_renderer_impl.cc
===================================================================
--- webkit/glue/media/video_renderer_impl.cc (revision 19826)
+++ webkit/glue/media/video_renderer_impl.cc (working copy)
@@ -9,12 +9,12 @@
namespace webkit_glue {
-VideoRendererImpl::VideoRendererImpl(WebMediaPlayerImpl* delegate)
- : delegate_(delegate),
+ VideoRendererImpl::VideoRendererImpl(WebMediaPlayerImpl::Proxy* proxy)
+ : proxy_(proxy),
last_converted_frame_(NULL) {
// TODO(hclam): decide whether to do the following line in this thread or
// in the render thread.
- delegate_->SetVideoRenderer(this);
+ proxy->SetVideoRenderer(this);
}
// static
@@ -25,7 +25,6 @@
return ParseMediaFormat(media_format, &width, &height);
}
-
bool VideoRendererImpl::OnInitialize(media::VideoDecoder* decoder) {
int width = 0;
int height = 0;
@@ -44,11 +43,14 @@
}
void VideoRendererImpl::OnStop() {
- delegate_->SetVideoRenderer(NULL);
+ DCHECK(proxy_);
+ proxy_->SetVideoRenderer(NULL);
+ proxy_ = NULL;
}
void VideoRendererImpl::OnFrameAvailable() {
- delegate_->PostRepaintTask();
+ DCHECK(proxy_);
+ proxy_->Repaint();
}
void VideoRendererImpl::SetRect(const gfx::Rect& rect) {
« no previous file with comments | « webkit/glue/media/video_renderer_impl.h ('k') | webkit/glue/webmediaplayer_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698