Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: PRESUBMIT.py

Issue 147221: Enforce correct mime-type on some files formats (especially images).... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/python 1 #!/usr/bin/python
2 # Copyright (c) 2009 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2009 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """Top-level presubmit script for Chromium. 6 """Top-level presubmit script for Chromium.
7 7
8 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for 8 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for
9 details on the presubmit API built into gcl. 9 details on the presubmit API built into gcl.
10 """ 10 """
(...skipping 19 matching lines...) Expand all
30 results.extend(input_api.canned_checks.CheckChangeHasNoTabs( 30 results.extend(input_api.canned_checks.CheckChangeHasNoTabs(
31 input_api, output_api, sources)) 31 input_api, output_api, sources))
32 results.extend(input_api.canned_checks.CheckChangeHasNoStrayWhitespace( 32 results.extend(input_api.canned_checks.CheckChangeHasNoStrayWhitespace(
33 input_api, output_api, sources)) 33 input_api, output_api, sources))
34 results.extend(input_api.canned_checks.CheckChangeHasBugField( 34 results.extend(input_api.canned_checks.CheckChangeHasBugField(
35 input_api, output_api)) 35 input_api, output_api))
36 results.extend(input_api.canned_checks.CheckChangeHasTestField( 36 results.extend(input_api.canned_checks.CheckChangeHasTestField(
37 input_api, output_api)) 37 input_api, output_api))
38 results.extend(input_api.canned_checks.CheckChangeSvnEolStyle( 38 results.extend(input_api.canned_checks.CheckChangeSvnEolStyle(
39 input_api, output_api, sources)) 39 input_api, output_api, sources))
40 results.extend(input_api.canned_checks.CheckSvnForCommonMimeTypes(
41 input_api, output_api))
40 return results 42 return results
41 43
42 44
43 def CheckChangeOnCommit(input_api, output_api): 45 def CheckChangeOnCommit(input_api, output_api):
44 results = [] 46 results = []
45 black_list = input_api.DEFAULT_BLACK_LIST + EXCLUDED_PATHS 47 black_list = input_api.DEFAULT_BLACK_LIST + EXCLUDED_PATHS
46 sources = lambda x: input_api.FilterSourceFile(x, black_list=black_list) 48 sources = lambda x: input_api.FilterSourceFile(x, black_list=black_list)
47 results.extend(input_api.canned_checks.CheckLongLines( 49 results.extend(input_api.canned_checks.CheckLongLines(
48 input_api, output_api, sources)) 50 input_api, output_api, sources))
49 results.extend(input_api.canned_checks.CheckChangeHasNoTabs( 51 results.extend(input_api.canned_checks.CheckChangeHasNoTabs(
50 input_api, output_api, sources)) 52 input_api, output_api, sources))
51 results.extend(input_api.canned_checks.CheckChangeHasNoStrayWhitespace( 53 results.extend(input_api.canned_checks.CheckChangeHasNoStrayWhitespace(
52 input_api, output_api, sources)) 54 input_api, output_api, sources))
53 results.extend(input_api.canned_checks.CheckChangeHasBugField( 55 results.extend(input_api.canned_checks.CheckChangeHasBugField(
54 input_api, output_api)) 56 input_api, output_api))
55 results.extend(input_api.canned_checks.CheckChangeHasTestField( 57 results.extend(input_api.canned_checks.CheckChangeHasTestField(
56 input_api, output_api)) 58 input_api, output_api))
57 results.extend(input_api.canned_checks.CheckChangeSvnEolStyle( 59 results.extend(input_api.canned_checks.CheckChangeSvnEolStyle(
58 input_api, output_api, sources)) 60 input_api, output_api, sources))
61 results.extend(input_api.canned_checks.CheckSvnForCommonMimeTypes(
62 input_api, output_api))
59 # Make sure the tree is 'open'. 63 # Make sure the tree is 'open'.
60 # TODO(maruel): Run it in a separate thread to parallelize checks? 64 # TODO(maruel): Run it in a separate thread to parallelize checks?
61 results.extend(CheckTreeIsOpen(input_api, output_api, 65 results.extend(CheckTreeIsOpen(input_api, output_api,
62 'http://chromium-status.appspot.com/status', 66 'http://chromium-status.appspot.com/status',
63 '0', 67 '0',
64 'http://chromium-status.appspot.com/current')) 68 'http://chromium-status.appspot.com/current'))
65 results.extend(CheckTryJobExecution(input_api, output_api)) 69 results.extend(CheckTryJobExecution(input_api, output_api))
66 return results 70 return results
67 71
68 72
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
130 text) 134 text)
131 if match: 135 if match:
132 long_text = match.group(1).strip() 136 long_text = match.group(1).strip()
133 except IOError: 137 except IOError:
134 pass 138 pass
135 return [output_api.PresubmitPromptWarning("The tree is closed.", 139 return [output_api.PresubmitPromptWarning("The tree is closed.",
136 long_text=long_text)] 140 long_text=long_text)]
137 except IOError: 141 except IOError:
138 pass 142 pass
139 return [] 143 return []
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698