Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: src/x64/codegen-x64.cc

Issue 147203: X64 implementation: Store to lookup slots (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/x64/codegen-x64.cc
===================================================================
--- src/x64/codegen-x64.cc (revision 2282)
+++ src/x64/codegen-x64.cc (working copy)
@@ -3870,8 +3870,6 @@
// TODO(X64): Enable more types of slot.
if (slot->type() == Slot::LOOKUP) {
- UNIMPLEMENTED();
- /*
ASSERT(slot->var()->is_dynamic());
// For now, just do a runtime call. Since the call is inevitable,
@@ -3879,8 +3877,8 @@
// arguments into place.
frame_->SyncRange(0, frame_->element_count() - 1);
- frame_->EmitPush(esi);
- frame_->EmitPush(Immediate(slot->var()->name()));
+ frame_->EmitPush(rsi);
+ frame_->EmitPush(slot->var()->name());
Result value;
if (init_state == CONST_INIT) {
@@ -3906,7 +3904,6 @@
// stack. This is necessary for compiling chained assignment
// expressions.
frame_->Push(&value);
- */
} else {
ASSERT(!slot->var()->is_dynamic());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698