Issue 147201: X64 Implementation: Implement floating-point compare

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 147201: X64 Implementation: Implement floating-point compare (Closed)

Created:
11 years, 6 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

X64 Implementation: Implement floating-point compare Committed: http://code.google.com/p/v8/source/detail?r=2281

Patch Set 1 #

Total comments: 4

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -6 lines)			Patch
	M	src/x64/codegen-x64.cc	View		5 chunks	+54 lines, -6 lines	2 comments	Download
	M	src/x64/macro-assembler-x64.cc	View		1 chunk	+9 lines, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

LGTM http://codereview.chromium.org/147201/diff/1/3 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/147201/diff/1/3#newcode5887 Line 5887: __ sar(kScratchRegister, Immediate(kSmiTagSize)); __ lea(kScratchRegister, Operand(lhs, lhs, ...

11 years, 6 months ago (2009-06-26 09:41:03 UTC) #2

William Hesse

11 years, 6 months ago (2009-06-26 19:45:59 UTC) #3

http://codereview.chromium.org/147201/diff/1/3
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/147201/diff/1/3#newcode5887
Line 5887: __ sar(kScratchRegister, Immediate(kSmiTagSize));
On 2009/06/26 09:41:04, Lasse Reichstein wrote:
> __ lea(kScratchRegister, Operand(lhs, lhs, times_1, 0));
> to do it in one operation.
> (Add ASSERT to check that kSmiTagSize is one and kSmiTag is zero).

Done.

http://codereview.chromium.org/147201/diff/1/2
File src/x64/macro-assembler-x64.cc (right):

http://codereview.chromium.org/147201/diff/1/2#newcode427
Line 427: sahf();
On 2009/06/26 09:41:04, Lasse Reichstein wrote:
> Add comment that sahf isn't safe to use. 
> We should add something to CpuProbe to test its availability, and find an
> alternative if it doesn't exist.

Done.

Expand Messages | Collapse Messages