Issue 147197: X64: Added support for "with" and "switch".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 147197: X64: Added support for "with" and "switch". (Closed)

Created:
11 years, 6 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
William Hesse

CC:
v8-dev

Visibility:
Public.

Description

X64: Added support for "with" and "switch".

Patch Set 1 #

Patch Set 2 : Also copied functions in frames.cc from ia32. #

Patch Set 3 : Fixed constants in frames-x64.h. Stacktraces work. #

Total comments: 1

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+187 lines, -21 lines)			Patch
M	src/x64/codegen-x64.cc	View	1	1 chunk	+153 lines, -6 lines	1 comment	Download
M	src/x64/frames-x64.h	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	src/x64/frames-x64.cc	View		2 chunks	+29 lines, -10 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

William Hesse

11 years, 6 months ago (2009-06-26 08:25:18 UTC) #2

LGTM.

http://codereview.chromium.org/147197/diff/6/7
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/147197/diff/6/7#newcode705
Line 705: // Verify that the runtime call result and esi agree.
rsi

Expand Messages | Collapse Messages