Issue 147163: GTK: Another attempt at fixing gtk_floating_container_forall() crasher.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 147163: GTK: Another attempt at fixing gtk_floating_container_forall() crasher. (Closed)

Created:
11 years, 6 months ago by Elliot Glaysher

Modified:
9 years, 7 months ago

Reviewers:
tony, Evan Martin, Evan Stade

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

GTK: Another attempt at fixing gtk_floating_container_forall() crasher. Tie the lifetime of the GtkFloatingContainer to TabContentsContainerGtk. Working theory is that we're leaking that reference, which is causing the crash. http://crbug.com/14485 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19282

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -10 lines)			Patch
	M	chrome/browser/gtk/tab_contents_container_gtk.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
	M	chrome/browser/gtk/tab_contents_container_gtk.cc	View		2 chunks	+10 lines, -9 lines	0 comments	Download

Total messages: 2 (0 generated)

Evan Stade

11 years, 6 months ago (2009-06-25 20:14:19 UTC) #2

On 2009/06/25 19:55:47, Elliot Glaysher wrote:
> [whoever gets to it first]

can't hurt, lgtm