Issue 147162: Ask for feedback one time out of 5, only when there is presubmit check notification.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 147162: Ask for feedback one time out of 5, only when there is presubmit check notification. (Closed)

Created:
11 years, 6 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Jói Sigurðsson

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Ask for feedback one time out of 5, only when there is presubmit check notification. TEST=unit test BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19429

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -4 lines)			Patch
	M	presubmit_support.py	View	1	4 chunks	+16 lines, -0 lines	1 comment	Download
	M	tests/presubmit_unittest.py	View		9 chunks	+17 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jói Sigurðsson

11 years, 6 months ago (2009-06-25 21:19:28 UTC) #2

LGTM with tiny nit

Down the line, you'll want to add a blacklist to not ask for feedback from
people you already know really hate presubmit scripts ;-)

http://codereview.chromium.org/147162/diff/1001/6
File presubmit_support.py (right):

http://codereview.chromium.org/147162/diff/1001/6#newcode789
Line 789: If may_prompt is true, output_streeam SHOULD be sys.stdout and
input_stream
output_streeam -> output_stream

Expand Messages | Collapse Messages