Issue 147148: Revert Linux sys_string_conversion changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 147148: Revert Linux sys_string_conversion changes. (Closed)

Created:
11 years, 6 months ago by Dean McNamee

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Revert Linux sys_string_conversion changes. This reverts r19239 and r19240. Tests are failing on the buildbots probably because they aren't in a UTF-8 locale. BUG=14826

Patch Set 1 #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -222 lines)			Patch
	M	base/sys_string_conversions_linux.cc	View		2 chunks	+4 lines, -109 lines	0 comments	Download
	M	base/sys_string_conversions_unittest.cc	View		2 chunks	+0 lines, -113 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

11 years, 6 months ago (2009-06-25 13:54:05 UTC) #2

I coulda sworn I did the review of these and suggested forcing a locale...

Expand Messages | Collapse Messages