Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2529)

Unified Diff: chrome/browser/history/history.h

Issue 147145: Fix: Certain redirections remove sites from the history... (Closed) Base URL: svn://chrome-svn.corp.google.com/chrome/trunk/src/
Patch Set: '' Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/bookmarks/bookmark_model_unittest.cc ('k') | chrome/browser/history/history.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/history.h
===================================================================
--- chrome/browser/history/history.h (revision 19705)
+++ chrome/browser/history/history.h (working copy)
@@ -155,13 +155,18 @@
// one entry). If there are no redirects, this array may also be empty for
// the convenience of callers.
//
+ // 'did_replace_entry' is true when the navigation entry for this page has
+ // replaced the existing entry. A non-user initiated redirect causes such
+ // replacement.
+ //
// All "Add Page" functions will update the visited link database.
void AddPage(const GURL& url,
const void* id_scope,
int32 page_id,
const GURL& referrer,
PageTransition::Type transition,
- const RedirectList& redirects);
+ const RedirectList& redirects,
+ bool did_replace_entry);
// For adding pages to history with a specific time. This is for testing
// purposes. Call the previous one to use the current time.
@@ -171,12 +176,13 @@
int32 page_id,
const GURL& referrer,
PageTransition::Type transition,
- const RedirectList& redirects);
+ const RedirectList& redirects,
+ bool did_replace_entry);
// For adding pages to history where no tracking information can be done.
void AddPage(const GURL& url) {
AddPage(url, NULL, 0, GURL::EmptyGURL(), PageTransition::LINK,
- RedirectList());
+ RedirectList(), false);
}
// Sets the title for the given page. The page should be in history. If it
« no previous file with comments | « chrome/browser/bookmarks/bookmark_model_unittest.cc ('k') | chrome/browser/history/history.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698